search

w3f / ring-proof

ring-vrf ring proof v2.5
Apache License 2.0
14 stars 4 forks source link

Merlin replaced with ark-transcript #29

Closed swasilyev closed 1 month ago

swasilyev commented 1 month ago

The only thing that we've decided for sure in w3f that we don't want merlin due to limited implementations and being tricky to specify. So so far as the simplest solution we have @burdges' ark-transcript.

davxy commented 1 month ago

@swasilyev for reference https://github.com/davxy/ring-proof/pull/3/files

As you can see in my draft PR the merlin stuff is gated by merlin feature and thus optional. The same can be done for ark-transcript (i.e. provide an implementation of your Transcript trait which uses ark-transcript).

Of course for JAM we'll specialize it to use ark-transcript. But, as said in the chat, I really like your ring lib to be not bound to a precise incarnation of transcript (as it is also generic for the curve) as it may be useful for other applications and people may want to use their stuff.

We 💕 generic transcripts 💕

davxy commented 1 month ago

https://github.com/w3f/ring-proof/pull/30

swasilyev commented 1 month ago

I think users can provide their implementation w/o extra feature