w3f / ring-vrf

MIT License
39 stars 17 forks source link

Use other basepoints #6

Open swasilyev opened 5 years ago

swasilyev commented 5 years ago

For fixed basepoint multiplication and also for Pedersen hashes we use basepoints provided by Zcash. We should better use our basepoints to prevent any kind of collision.

burdges commented 4 years ago

We've no problem for the Schnorr DLEQ proof here. And the SNARK should handle the same points too, no? Are you worried about Pederson hashes agreeing due to people reusing keys?

swasilyev commented 4 years ago

Smth like that. Anyway it's obviously not less safer to have custom Personalization. Maybe in Zexe version

burdges commented 4 years ago

We'll see how ZEXE handles JubjubEngine::Params too, maybe my JubjubEngineWithParams became unnecessary, or maybe we want it for exactly this.