search

w3f / ring-vrf

MIT License
39 stars 17 forks source link

Remove UnsafeCell (Attempt 2) #88

Open davxy opened 6 months ago

davxy commented 6 months ago

Superseeds https://github.com/w3f/ring-vrf/pull/87

davxy commented 6 months ago

@burdges do you think this is good to be merged?

burdges commented 6 months ago

I see, 2af5bd2 reverts 4c7eba5. I'll go through the finished change, not the individual commits. ;)

davxy commented 6 months ago

I see, 2af5bd2 reverts 4c7eba5. I'll go through the finished change, not the individual commits. ;)

Yeah. I decided to revert because that modification was using the secret for the computation: res = (A+B)*c = secret*c). The original code was better as it doesn't reconstruct the secret to compute the result res = (A*c + B*c).

Doing the computation with the reconstructed secret makes the splitting trick pointless