w3f / rs-ec-perf

3 stars 3 forks source link

Make the argument to encode and decode, member of ReedSolomon struct #11

Closed drskalman closed 3 years ago

drskalman commented 3 years ago

Just making the code more object oriented.

drskalman commented 3 years ago

cc15288 takes care of most of it. though I'm getting this error:

    error: unconstrained generic constant
   --> reed-solomon-novelpoly/src/novel_poly_basis/mod.rs:193:46
    |
193 |         let mut error_poly_in_log = [Logarithm(0); F::FIELD_SIZE];
    |                                                    ^^^^^^^^^^^^^
    |
    = help: try adding a `where` bound using this expression: `where [(); F::FIELD_SIZE]:`

@burdges could you help or I should give up and use a vector?

drskalman commented 3 years ago

changed to vector for now cc1cf98 is basically implement what this issue asks for.

drskalman commented 3 years ago

Now we are block by #12