search

w3f / schnorrkel

Schnorr VRFs and signatures on the Ristretto group
BSD 3-Clause "New" or "Revised" License
314 stars 93 forks source link

Update travis.yml, add clippy, rust fmt #13

Closed liamsi closed 5 years ago

liamsi commented 5 years ago

While skimming through this repo, I've noticed a few things that a .travis.yml exists but still seems to contain arteefacts from dalek-cryptography? https://github.com/w3f/schnorrkel/blob/eaf66334f251984a9a9dd545a1c3bb043da62e12/.travis.yml#L30 I think re-enabling travis, and at least adding rust fmt, clippy, cargo audit (and maybe other lints), would help to keep the code quality high.

burdges commented 5 years ago

Yeah there is likely more of this, well this crates started kinda haphazardly. ;)

liamsi commented 5 years ago

I don't have the permissions to enable travis for this repo. But this is certainly sth. to consider rather sooner than later.

burdges commented 5 years ago

Someone with owner access to w3f turned travis on

liamsi commented 5 years ago

As far as I can tell no travis build was triggered yet though. NVM, it works now.

liamsi commented 5 years ago

Not sure if that's relevant but this fails to build with the feature u32_backend https://travis-ci.org/w3f/schnorrkel/jobs/508081162

burdges commented 5 years ago

I never kept up with the full feature set from ed25519-dalek while doing this, so not surprised. We'll fix them all eventually.

liamsi commented 5 years ago

Probably worth disabling that build step until fixed.