w3f / schnorrkel

Schnorr VRFs and signatures on the Ristretto group
BSD 3-Clause "New" or "Revised" License
310 stars 93 forks source link

Audit error paths #29

Open burdges opened 5 years ago

burdges commented 5 years ago

We ocasionally have multiple error paths, one early error stemming from point decompression failure, and a second main error stemming for signature verification failure, but in places the first error should always be interpreted as a signature verification failure.

We must review all these error paths to help ensure developers treat them appropriately, maybe meaning equally, even if this requires keeping some types as [u8; ..] until verification.