w3f / schnorrkel

Schnorr VRFs and signatures on the Ristretto group
BSD 3-Clause "New" or "Revised" License
312 stars 93 forks source link

verify_batch regression #3

Closed burdges closed 4 years ago

burdges commented 5 years ago

There was a 19% performance regression in verify_batch somewhere in the switch to merlin in #2 . I'm not going to track it down anytime soon, but worth noting. I donno if it happened before or after switching transcripts to be an iterator, so maybe I'm handling the iterator poorly, or maybe it was cache locality I fixed it already by switching to the iterator, or maybe its simply that verify_batch is more sensitive to hashing and marlin is slow, but both sound unlikely.