search

w3f / schnorrkel

Schnorr VRFs and signatures on the Ristretto group
BSD 3-Clause "New" or "Revised" License
306 stars 92 forks source link

change dalek dependency to the commit that fixes simd issue #62

Closed ghost closed 3 years ago

ghost commented 3 years ago

Meant to submit to a fork. But, it would be great if you could update your dalek dependency to a version that fixes packed_simd issue. You can find more about it in https://github.com/dalek-cryptography/curve25519-dalek/issues/333

burdges commented 3 years ago

We cannot publish a git rev dependency on crates.io I think, so we must wait until curve25519-dalek fixes this before releasing a version. Are you just asking for a temporary [patch] fix in master here?

If I understand, this should work either if done here, and maybe if done in your downstream code: 

[patch.curve235519-dalek]
packed_simd = { version = "0.3.4", package = "packed_simd_2", features = ["into_bits"], optional = true }

If I [patch] here, then you're left using git = for schnorrkel, but if the above works in your downstream code, then we've only one temporary change, right?

ghost commented 3 years ago

Nice, that looks very promising. For now, I've made o fork https://github.com/PolymathNetwork/schnorrkel and have pinned it to a rev. But I like your solution more, so I'll test it and let you know sometime on Monday.

burdges commented 3 years ago

I know crates.io allows package = but forbids git dependencies. I'm unsure about [patch] either way, but I'd prefer schnorrkel stay in sync with curve25519-dalek releases if possible.