search

w3f / schnorrkel

Schnorr VRFs and signatures on the Ristretto group
BSD 3-Clause "New" or "Revised" License
309 stars 93 forks source link

set minimum subtle version to 2.4.1 #99

Closed andresilva closed 10 months ago

andresilva commented 10 months ago

This is to help with https://github.com/paritytech/polkadot-sdk/pull/2524#issuecomment-1847055347. If you agree with this change and merge it please release schnorrkel 0.11.4 afterwards.

burdges commented 10 months ago

Interestingly, dalek itself only uses subtle 2.3, so yes let's merge this once CI runs. We only switched to 2.5 due to using -ng for a while, or due to blindly upgrading.

I've no idea why subtle dislikes having multiple versions. I found no #[no_mangle] in 2.5, and the trait wind up compatible somehow.

In principle of course, subtle should be upgraded because it's providing contant time tooling, but if dalek felt no need to upgrade yet, then we're fine too.

andresilva commented 10 months ago

Don't forget to publish 0.11.4 with this so we can use it on polkadot :)

burdges commented 10 months ago

Done

burdges commented 9 months ago

We'll probably have more mess from https://github.com/dalek-cryptography/subtle/pull/118 in future