w3f / substrate

Fork of parity Substrate to help W3F researchers to contribute to the code.
Apache License 2.0
0 stars 0 forks source link

Make the test keyring enum to work for different keystores #2

Closed drskalman closed 1 year ago

drskalman commented 1 year ago

Beefy keystore tests uses Keyring enum, which contains the identity of test accounts in validator set. It has been implemented for ecdsa_crypto. To make the implementation generic over the choice of crypto, we add GenericKeyring trait which is generic over the (Key)Pair and then we implement it for the Keyring enum.

drskalman commented 1 year ago

It is working for ecdsa for now, though we need to implement Pair for ECDSAnBLS to be able to have generic tests which work for both scheme.

drskalman commented 1 year ago

The approach is implemented in d93fca0a90