search

w3guy / persist-admin-notices-dismissal

Simple plugin that persists dismissal of admin notices across pages in WordPress dashboard.
http://w3guy.com/wordpress-admin-notices-dismissible/
87 stars 22 forks source link

Use options not transients #18

Closed afragen closed 5 years ago

afragen commented 5 years ago

Hopefully this plays nicer with object caching. Fixes https://github.com/collizo4sky/persist-admin-notices-dismissal/issues/17

afragen commented 5 years ago

Just need to remember to tag release 1.4.0

afragen commented 5 years ago

@collizo4sky Hold off on merging. I thought of a slightly better plan to put all the options in single array. It will make cleanup simpler.

w3guy commented 5 years ago

I’ll hold

On Tue, 23 Oct 2018 at 3:34 PM, Andy Fragen notifications@github.com wrote:

@collizo4sky https://github.com/collizo4sky Hold off on merging. I thought of a slightly better plan to put all the options in single array. It will make cleanup simpler.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/collizo4sky/persist-admin-notices-dismissal/pull/18#issuecomment-432271195, or mute the thread https://github.com/notifications/unsubscribe-auth/AD8uc77R6juHCxFThdzxovgo44C7uja7ks5unykTgaJpZM4X0lzu .

afragen commented 5 years ago

Go ahead. It was getting overly complex for the perceived gain.

afragen commented 5 years ago

@collizo4sky this works for me, OK for merge after your review. Please remember to tag release. 😉

w3guy commented 5 years ago

I'll test now and merge.