w3guy / persist-admin-notices-dismissal

Simple plugin that persists dismissal of admin notices across pages in WordPress dashboard.
http://w3guy.com/wordpress-admin-notices-dismissible/
90 stars 22 forks source link

Fixes by WPCS #34

Closed cherrypickstudios closed 3 years ago

cherrypickstudios commented 3 years ago
afragen commented 3 years ago

There were also a number of other WPCS issues. I've included some modifications to your PR and the other updates in #36

w3guy commented 3 years ago

Fixed in #36

Surbma commented 3 years ago

@w3guy The first WPCS error is not fixed:

Version parameter is not explicitly set or has been set to an equivalent of "false" for wp_enqueue_script; This means that the WordPress core version will be used which is not recommended for plugin or theme development. (WordPress.WP.EnqueuedResourceParameters.NoExplicitVersion)

Please use the version number instead of "false".

w3guy commented 3 years ago

@Surbma please submit a pull request

Surbma commented 3 years ago

@w3guy Original PR was already sent with this fix, but I just submitted a new PR with this fix. Thank you!