search

w3guy / persist-admin-notices-dismissal

Simple plugin that persists dismissal of admin notices across pages in WordPress dashboard.
http://w3guy.com/wordpress-admin-notices-dismissible/
87 stars 22 forks source link

use transient instead of option #8

Closed afragen closed 8 years ago

afragen commented 8 years ago

uses AUTH_COOKIE as salt. This should fix #7

w3guy commented 8 years ago

Will test and get back to you. In the mean time, can you update the readme as stated in #5

afragen commented 8 years ago

After sleeping on it I'm now sure the salt is needed.

afragen commented 8 years ago

Will test and get back to you. In the mean time, can you update the readme as stated in #5

Done. https://github.com/collizo4sky/persist-admin-notices-dismissal/commit/b986715ea7d8151e5c66ea16487eada09b0f65f6

afragen commented 8 years ago

I've been testing and it seems to work great. I think using transients will be preferable so we don't leave lots of clutter in the options table.

w3guy commented 8 years ago

Could you please merge this and i will get it tagged and released tomorrow.

On Fri, Aug 12, 2016 at 8:09 PM, Andy Fragen notifications@github.com wrote:

I've been testing and it seems to work great. I think using transients will be preferable so we don't leave lots of clutter in the options table.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/collizo4sky/persist-admin-notices-dismissal/pull/8#issuecomment-239534553, or mute the thread https://github.com/notifications/unsubscribe-auth/AD8uc38gW-NToHDJwC7i3WnWONGx2Fr5ks5qfMUCgaJpZM4JixbV .

w3guy commented 8 years ago

Released 😄