search

w3lh / w3l

Warcraft III TFT/RoC PvPGN Loader
GNU General Public License v3.0
53 stars 25 forks source link

1.28.5 support #6

Closed cen1 closed 7 years ago

cen1 commented 7 years ago

Patching of Warcraft III.exe fails:

Warcraft III.exe:
Read ebx:0xFE9CF000
base: 1380000
[w3l] Trying base offset 0x00061A64 with base 0x01380000...Bad offset

if old war3.exe stil exists in the directory it will patch it successfuly but that it a false success (w3 even shows up to date version in old binary, weird).. since versioncheck to pvpgn is the old one.

cen1 commented 7 years ago

Apparently correct offset is 0x00061A74, also for 1.28.4 (current one is wrong). It is off by 0x10

w3lh commented 7 years ago

For 1.28.4 0x00061A64 looks fine for me: Warcraft III.exe: Read ebx:0x00F43000 base: 150000 [w3l] Trying base offset 0x00061A64 with base 0x00150000...Success. Warcraft III.exe version 1.28.4.7608, size 561 128 bytes

cen1 commented 7 years ago

Looks like I did a bad clean copy of 1.28.4 and have the wrong Warcraft III.exe in my folder (forgot to back it up and got overriden by 1.28.5). Anyway, 1.28.5 seems to be correct.