search

w3nl / ppt-png

Convert ppt to png
MIT License
45 stars 7 forks source link

Setting width and height #26

Closed rayit closed 3 years ago

rayit commented 3 years ago

When setting width and height it's not using it because density is filled in when not provided

w3nl commented 3 years ago

Indeed i see it. https://github.com/w3nl/ppt-png/blob/master/js/convert.js#L31 (always set the density) https://github.com/w3nl/ppt-png/blob/master/js/pdf2image.js#L323 (check if density is set) Can you create a pull request with the fix?

rayit commented 3 years ago

Never done that before will give it a try..

w3nl commented 3 years ago

I have publish the version with your fix: https://www.npmjs.com/package/ppt-png/v/0.7.2

rayit commented 3 years ago

super, heel erg bedankt!

Dan kan ik mijn fork deleten.

gr

Raymond Marx

On 2020-12-18 14:21, HckrNews wrote:

I have publish the version with your fix: https://www.npmjs.com/package/ppt-png/v/0.7.2

-- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub [1], or unsubscribe [2].

Links:

[1] https://github.com/w3nl/ppt-png/issues/26#issuecomment-748080854 [2] https://github.com/notifications/unsubscribe-auth/ABCXNAWZCQXINKUSSNCTIGLSVNJNNANCNFSM4UWVZ5CA