String - Spec `minLength` & `maxLength`

w3r-one / json-schema-bundle

serialize Symfony Forms into JSON schema

MIT License

3 stars 0 forks source link

String - Spec `minLength` & `maxLength` #4

Open laurent-bientz opened 1 year ago

laurent-bientz commented 1 year ago

https://json-schema.org/understanding-json-schema/reference/string.html#length

We need to check:

ORM nullable capability to force minLength: 1 if not nullable
ORM type to set the max
form Constraint
object Assert
form attr.minlength & attr.maxlength

solverat commented 3 months ago

Hey @laurent-bientz. We're currently evaluating this bundle, and it looks very promising. However, it seems, development has stopped last year, I'm wondering if this is an active project?

laurent-bientz commented 3 months ago

Hello @solverat, this bundle is actively used internally on several (big) projects in production but you're right, we are running out of time to develop it deeper.

Actually the state of this bundle and the related front-end is stable and enough to meet ours actual needs.

If you want to contribute to the "missing" features, feel free to open a PR.

It's a complex part that requires time because we need to perform a lot of "reflections" on various vendors to bring these features!

solverat commented 3 months ago

@laurent-bientz I know the pain… :) We're evaluating the support of JSON schema support for our form builder (also open source) and surprisingly, there are not many alternatives out there. Limenius was on our track, but it seems to be dead (besides of some forks).

However, I think we're going to give this one a try, since it have a very solid, clean and nice codebase, the to-dos are well-defined.

First, I'm going to open issues, for everything which seems to be missing, if that's okay. If we're able to fulfill our requirements in the end, we're happy to provide some PRs (if required).

laurent-bientz commented 3 months ago

Hey @solverat, sounds good to me!

And yes, we also used Limenius before but the project didn't follow the json specs 100% and it was very difficult to discuss with the creator (if u're curious: https://github.com/Limenius/LiformBundle/issues/28), that's why we decided to start from scratch and not fork his work.