search

w3st-io / trading-bot

Coinbase Trading Bot
0 stars 1 forks source link

Are wrappers for the coinbase-pro api necessary? #1

Open jkahanec opened 4 years ago

jkahanec commented 4 years ago

https://github.com/aleem-ahmed/eccentric-trader/blob/0691dce6c969561bb316a21b45a4296e3b030437/client/coinbase/CBAuthClient.js#L26 https://github.com/aleem-ahmed/eccentric-trader/blob/0691dce6c969561bb316a21b45a4296e3b030437/client/coinbase/CBPublicClient.js#L15

Why do these classes exist? are they necessary? Why can you not just call the API directly?

It looks like you were attempting to make a Shim, but it turned out to be a Middle Man.

aleem-ahmed commented 4 years ago

this is a valid point you are making.. i cannot give a clear answer as to why this exists. maybe in the future, I might need to make some modifications to the params before sending a request to the API. but as of yet, there is pretty much no reason for it to exist except to keep things organized for me as the dev.