search

w3st-io / trading-bot

Coinbase Trading Bot
0 stars 1 forks source link

Define constants instead of using "Magic Strings" #3

Open jkahanec opened 4 years ago

jkahanec commented 4 years ago

https://github.com/aleem-ahmed/eccentric-trader/blob/0691dce6c969561bb316a21b45a4296e3b030437/client/collections/TickersCollection.js#L28

Careful using Magic Strings, it's a serious antipattern. If you want more info, google "Magic Strings" and you will see plenty of anecdotes.

aleem-ahmed commented 4 years ago

will get back to you after i learn what a magic String is.