search

w3tecch / typeorm-seeding

🌱 A delightful way to seed test data into your database.
https://www.npmjs.com/package/typeorm-seeding
MIT License
877 stars 131 forks source link

Swap out Faker for @faker-js/faker #206

Closed kevin-mitchell closed 2 years ago

kevin-mitchell commented 2 years ago

After the "switcheroo" that was pulled with Faker, I imagine that it would be a good idea to switch Faker out for the accepted "official" fork of the original project.

See: https://fakerjs.dev/

My understanding is that the best way to approach this swap would be to wait for the 6.0.0 release of @faker-js/faker (as of this ticket being created the current package is 6.0.0-alpha.5), then "just" swap out the libraries.

In a very quick test I found that it seems pretty simple to swap out "old faker" for "new faker", although I followed these steps https://github.com/faker-js/faker#typescript-support to make TypeScript happy (this may be unnecessary).

jorgebodega commented 2 years ago

Hi! I can make this change, but pls take a look on #201