search

w3tecch / typeorm-seeding

🌱 A delightful way to seed test data into your database.
https://www.npmjs.com/package/typeorm-seeding
MIT License
877 stars 131 forks source link

use the new package faker-js #216

Closed yabbal closed 2 years ago

Falumpaset commented 2 years ago

this would be greatly appreciated

xDivisionByZerox commented 2 years ago

I think just updating the package file will not do it. Just a quick scan over the project revealed a couple of references to the faker library (even in the docs). You should provide updates to all those occurrences, and not only install the newer package.

@AbbalYouness are you willing to do that? Otherwise, I would like to take over your PR. I'm a member of the team that works on the @faker-js/faker package.

yabbal commented 2 years ago

I leave you this PR with pleasure ! I let you open an new PR and I close this one. Thank you mate 😊