youporn broken due to non escaped spaces in filenames

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Try to open any video on YouPorn that has a space in the title.

What is the expected output? What do you see instead?
ERROR: XFILE::CFileCache::Open - failed to open source 
<http://videos-9.youporn.com/l3-1000k/save/h264_640w_main_370k/7634079/YouPorn 
- Beach Patrol Vol 3 Part 2.
mp4?nva=20120314162606&hash=024ba7fd5d5cbf32a2800>

What version of the product are you using? On what operating system?
latest update on windows.

Please provide any additional information below.
Fix: Substitute each space in the filename with "%20".

Original issue reported on code.google.com by leonmar...@gmail.com on 12 Mar 2012 at 4:39

[GoogleCodeExporter]

That video works fine for me, but I will see if replacing the spaces does not 
break anything

Original comment by mrdougqu...@gmail.com on 13 Mar 2012 at 10:25

• Changed state: Accepted

[GoogleCodeExporter]

Could it be a windows specific error or a libcurl one?

Because "curl -I http://videos...." with the spaces returns an error code "400 
Bad Request".
While "curl -I http://videos..." with escaped spaces (%20) returns a "200 OK" 
code and the video can be transferred as expected.

Original comment by leonmar...@gmail.com on 13 Mar 2012 at 2:04

[GoogleCodeExporter]

I suspect curl -l "http://...." would work 

try deleting the action=decode in catcher.list and see if that works. The 
problem with doing that for me is that the "&" becomes "&" and that fails to 
play

also try adding 
player=mplayer
right after the catcher= line in youporn.cfg file

mix and match the suggestions and let me know if any of them work

Original comment by mrdougqu...@gmail.com on 13 Mar 2012 at 2:19

[GoogleCodeExporter]

> try deleting the action=decode in catcher.list and see if that works. The 
problem with doing that for me is that the "&" becomes "&" and that fails to 
play

You mean the "&hash" becomes "&hash", right? I can confirm that this happens, 
although (on a different bug perhaps) when selecting a video with a "&" in its 
name, the "&" gets omitted no matter if "action=decode" is on or off. Search 
for "Nicole Aniston" and open up the video "Big Tit & Ass blonde Pornstar 
Nicole Aniston fucks trainer in gym"
You'll see this:

NOTICE: DVDPlayer: Opening: 
http://videos-2.youporn.com/l3-1000k/save/h264_640w_main_370k/7625022/YouPorn - 
Big Tit Ass blonde Pornstar Nicole Aniston fucks trainer in 
gym.mp4?nva=20120315160245&hash=0219cd75212adcf8e4859

...where the "&" is completely omitted from the curl input.

> also try adding player=mplayer right after the catcher= line in youporn.cfg 
file

Tried every combination of "mplayer", "Mplayer", "MPlayer" to no avail.
In the logfile I still get "NOTICE: DVDPlayer:..."  and 
"XFILE::CFileCurl::CReadState::FillBuffer: curl failed with code 22" which 
according to libcurl error codes means that a 4xx error occured. 

Original comment by leonmar...@gmail.com on 13 Mar 2012 at 4:18

[GoogleCodeExporter]

Another thing in addition to the issue that "&" being omitted from the 
filename. The same happens for the single quote " ' ".

Original comment by leonmar...@gmail.com on 13 Mar 2012 at 4:32

[GoogleCodeExporter]

Take a look at the structure of these two links.
http://videos-2.youporn.com/l3-1000k/save/h264_640w_main_370k/7625022/YouPorn - 
Big Tit Ass blonde Pornstar Nicole Aniston fucks trainer in 
gym.mp4?nva=20120316015529&hash=01baee773aeaba6532649

http://videos-2.youporn.com/l3-1000k/h264_640w_main_370k_flv/7625022_Big_Tit_Ass
_blonde_Pornstar_Nicole_Aniston_fucks_trainer_in_gym.flv?nva=20120316015420&hash
=02b6da61d2e7d5b01742e

The first one is from videodevil's/youporn processor, while the second one is 
from another add-on.

Now, the second link returns a FLV file (instead of an MP4), has underscores 
instead of spaces and if it where to be implemented, it does not require the 
disabling of the "action=decode" directive. 

The resulting file is of similar quality and size (size of MP4 = 20488164, size 
of FLV = 19680015) and plays flawlessly on XBMC.

Original comment by leonmar...@gmail.com on 14 Mar 2012 at 2:03

[GoogleCodeExporter]

This issue was closed by revision r83.

Original comment by mrdougqu...@gmail.com on 14 Mar 2012 at 11:55

• Changed state: Fixed

[GoogleCodeExporter]

It is not great because flv files are not seekable whereas the mp4 were, but if 
it means it works for everyone then .... 

Original comment by mrdougqu...@gmail.com on 14 Mar 2012 at 11:58

[GoogleCodeExporter]

Are you sure about that? This version works as expected (kudos for the fast 
implementation!) and I have no problem seeking into any file either by 
"left/right" keys, or by ",/." keys, or by exact time point, such as "03:00".

Original comment by leonmar...@gmail.com on 14 Mar 2012 at 3:07

[GoogleCodeExporter]

It is just that when you seek in the flv (press up arrow) it looks like you 
have to wait until it downloads the bits you skipped whereas in the mp4 file it 
it starts playing pretty quickly. Isn't that what you get?

 If I have the time I will have a look at fixing it so that we can have mp4s

Original comment by mrdougqu...@gmail.com on 14 Mar 2012 at 11:10

[GoogleCodeExporter]

Interestingly enough, that only happens for videos longer than 20 minutes (that 
means when the "up/down" keys seek for +/- 10 minutes). In shorter videos, the 
up/down keys seek for less than 10 minutes (usually, for 1-3 minutes) and the 
bug that you describe does not show up.

Original comment by leonmar...@gmail.com on 15 Mar 2012 at 2:46

[GoogleCodeExporter]

You must have a faster connection, if the video has been downloaded to the 
point you want to seek to it just plays otherwise you have to wait until the 
download reaches the point you have seeked to with flv. 

Original comment by mrdougqu...@gmail.com on 15 Mar 2012 at 10:46

[GoogleCodeExporter]

Url is now encrypted but the download URL still works

Original comment by mrdougqu...@gmail.com on 22 Jul 2012 at 9:39

• Changed state: New

[GoogleCodeExporter]

Original comment by mrdougqu...@gmail.com on 22 Jul 2012 at 9:39

• Changed title: youporn broken due to non escaped spaces in filenames

[GoogleCodeExporter]

This issue was closed by revision r119.

Original comment by mrdougqu...@gmail.com on 22 Jul 2012 at 12:21

• Changed state: Fixed