w7cook / OpenBook

a project to create a basic social networking site
http://www.cs.utexas.edu/~wcook/Courses/devclass/index.htm
25 stars 20 forks source link

UI overhaul to fix various issues. #284

Closed tkeeler closed 5 years ago

tkeeler commented 12 years ago

This UI overhaul should fix a few of the various glitches.

240, #278, #257

While working noticed that link was still unfinished, so I merge the code I thought I had already submitted and got it working again.

amshali commented 12 years ago

@ProCynic , @jtessler can you help reviewing this?

amshali commented 12 years ago

I personally do not like the current changes to the UI by this set. Let's hear other's opinion.

jtessler commented 12 years ago

It probably isn't necessary to add a 100x100 thumbnail when we could just resize the 120x120. I've also considered removing all thumbnails except 150x150, then resize where needed. I believe 150x150 is already small enough to reduce loading times; anything else is superfluous.

However, if you do want to keep the 100x100, mind adding a route to conf/routes?

I'll review the UI changes shortly.

jtessler commented 12 years ago

I added some screenshots to quickly compare the changes: http://imgur.com/a/x75MX

I personally like the fixed width style and keeping the right-side nav stationary while scrolling. However, the left-side nav seems too skinny now and its style doesn't match the right-side one (no shadows).

I'm not sure about moving the profile thumbnails outside of the post box, but it may grow on me.