Closed slongberry closed 9 years ago
@slongberry, you did just right, maybe you can adapt that into a pull request?
I'll send you the PR on Monday morning.
Scott
Sent from my iPhone
On Jul 3, 2015, at 3:26 AM, Alexander Milevski notifications@github.com wrote:
@slongberry, you did just right, maybe you can adapt that into a pull request?
— Reply to this email directly or view it on GitHub.
PR submitted. As it is my first PR submitted on Github, please let me know if I need to change anything / do anything differently!
@slongberry, thanks! merged, re-built, published
Really like the plugin, it has saved me a ton of time. I have come across one issue though.
We have the ability to customize the way the list of bookmarks appears through the bookmarkTemplate option. However, if I add a custom field to the bookmark, I don't see how to access that data to display it.
I modified the _getBookmarkDataForTemplate function in the code to look more like the _getPopupContent function:
This allowed me to write me own custom getBookmarkDataForTemplate function and pass it to the bookmarks control as an option on creation. If there is another way that I should have accessed the data, please let me know.