search

w8r / splay-tree

Fast splay-tree data structure
https://npm.runkit.com/splaytree
114 stars 18 forks source link

remove() always returns undefined #7

Open mfogel opened 5 years ago

mfogel commented 5 years ago

Hi @w8r, thanks for your work on splay-tree. Very helpful lib.

Per the docs in the README, remove() is intended to return a boolean. Per the docs in remove()'s docstring, it should return a node or null. However, it just returns undefined, irrespective of whether it removed anything or not from the tree.

Note that it appears this is addressed by an open PR: #5