w8tcha / CKEditor-TextSelection-Plugin

The plugin that makes the editor keep it's text-selection when switching between WYSIWYG and Source mode, and scrolls the selection into the viewport.
MIT License
10 stars 7 forks source link

Undo history gets messed up after viewing the source #15

Closed skegel13 closed 9 years ago

skegel13 commented 9 years ago

With this plugin enabled, the undo plugin gets messed up. Undoing will go back to when you viewed the source and no more undo history is added after viewing the source. So a lot of data can be lost when using undo after viewing the source.

This seems to occur only in the latest version. I tested the older version and did not run into this issue.

w8tcha commented 9 years ago

Sorry but i can not reproduce this.

I tried to reproduce...

Works as it should be

skegel13 commented 9 years ago

The problem seems to occur when using the CKEditor builder with the compressed code and this plugin added. I can reproduce it on your demo page as well (https://w8tcha.github.io/CKEditor-TextSelection-Plugin/demoFramed.html).

To reproduce:

Again, this occurs with the CKBuilder version using compressed code. When installing the plugin manually, I run into another issue which I will post as well (https://github.com/w8tcha/CKEditor-TextSelection-Plugin/issues/16).