w9jds / firebase-action

GitHub Action for interacting with Firebase
MIT License
927 stars 200 forks source link

Add support for function envrionment variables #113

Closed irby closed 2 years ago

irby commented 3 years ago

Based on Issue #86, add in support for passing environment variables to the action.

irby commented 3 years ago

@w9jds

irby commented 3 years ago

Thanks for approving @w9jds :) I don't have write access so I'm unable to complete the PR

w9jds commented 3 years ago

Yeah, that is intended. Just wanted to look into something before merging this. Most of the issues related to this creation seem to be caused by service accounts not having proper permissions. I want to make sure this works with paths to files too as setting them in secrets only doesn't make the most sense.

w9jds commented 2 years ago

If you want to pull the :master image you can test this in a real flow @irby sorry for the huge delay 😟