w9jds / firebase-action

GitHub Action for interacting with Firebase
MIT License
923 stars 198 forks source link

regression of #115? #119

Closed banyan closed 2 years ago

banyan commented 2 years ago

I've been using this github action for over a year without any problems. However, the job is failing since today.

My GCP_SA_KEY is encoded as base64.

image The base64 encoded key should be this block, but the log shows that it is evaluated at the bottom.

workaround: use w9jds/firebase-action@v1.5.0 instead of w9jds/firebase-action@master

sasamuku commented 2 years ago

I am facing the same problem.

I tried the following workaround, but the problem didn't solved.

I've been using GCP_SA_KEY which is base64 encoded as well.

w9jds commented 2 years ago

Thanks for the better implementation for this, I tested it locally and merged it. This should be fixed for jobs going forward 🤞

banyan commented 2 years ago

Thanks for the quick review and merge!