w9jds / firebase-action

GitHub Action for interacting with Firebase
MIT License
922 stars 198 forks source link

Node.js version 16 no longer supported. #204

Closed xylo04 closed 9 months ago

xylo04 commented 10 months ago

Starting today, I'm getting the message:

Node.js version v16.16.0 detected.
The Angular CLI requires a minimum Node.js version of v18.13.
w9jds commented 10 months ago

I'm not sure if this will affect things around firebase functions as I think they are still mainly Node 16. This seems to be related to an experimental framework support for Firebase Hosting which needs to use other CLIs to properly compile your project and is directly related to Angular CLI not Firebase CLI. Out of curiosity, if you use setup-node and setup-firebase instead to specify specific versions, does that work?

xylo04 commented 10 months ago

I'm using setup-node with node 18, but that doesn't seem to affect the node version inside the action's container.

I'll also note that Node 16 is end of life and no longer maintained, and Firebase Functions definitely supports 18 and 20.

artanisdesign commented 9 months ago

Hi!

Same issue here:

error functions@1.0.0: The engine "node" is incompatible with this module. Expected version "18". Got "16.16.0" error Found incompatible module.

my functions are on 18, also setup node is on 18. still this step wanna use 16 :/

w9jds commented 9 months ago

setup-node does nothing for this as it's a docker action, that is why I suggested trying my setup-firebase that is a revamp of this action but more flexible and powerful. I will take a look at merging this in.

xylo04 commented 9 months ago

I'm open to trying your other action https://github.com/w9jds/setup-firebase. I was a little worried because it hasn't received any updates in a while, but I'll give it a shot.

w9jds commented 9 months ago

The nice thing about that one, is that it doesn't need updates. You tell it what version you want to use and it just pulls it as needed. It's why I created it, it allows you to specify the Firebase-tools version and use things like setup-java and setup-node so you get way more flexibility. If it all works with the newer node let me know, I'm also going to look into the PR.

w9jds commented 9 months ago

Let me know if setup-firebase worked, I also merged in your PR for node 18.