search

w9jds / firebase-action

GitHub Action for interacting with Firebase
MIT License
922 stars 198 forks source link

Firebase CLI 13.0.1 and Node.js 16 incompatible error after 13.0.1 update #214

Closed tjmtic closed 9 months ago

tjmtic commented 9 months ago

Just started getting this error: Firebase CLI v13.0.1 is incompatible with Node.js v16.16.0 Please upgrade Node.js to version >=18.0.0 || >=20.0.0

After rolling back to v12.9.0, it is successful again.

This seems strange, of course, since I thought this node version was what was updated; if I am missing something here I apologize.

emedd33 commented 9 months ago

Changing back to uses: w9jds/firebase-action@v12.9.0 worked for me also

lhermann commented 9 months ago

I get the same error.

Relevant excerpts from the log:

2023-12-08T17:30:37.6969940Z ##[group]Runner Image
2023-12-08T17:30:37.6970512Z Image: ubuntu-22.04
2023-12-08T17:30:37.6971052Z Version: 20231205.1.0
...
2023-12-08T17:31:13.2663970Z ##[group]Run actions/setup-node@v3
2023-12-08T17:31:13.2664430Z with:
2023-12-08T17:31:13.2664734Z   node-version: 18
2023-12-08T17:31:13.2665072Z   always-auth: false
2023-12-08T17:31:13.2665441Z   check-latest: false
2023-12-08T17:31:13.2665997Z   token: ***
2023-12-08T17:31:13.2666311Z ##[endgroup]
2023-12-08T17:31:13.5225564Z Found in cache @ /opt/hostedtoolcache/node/18.19.0/x64
2023-12-08T17:31:13.5238146Z ##[group]Environment details
2023-12-08T17:31:14.0587123Z node: v18.19.0
2023-12-08T17:31:14.0587935Z npm: 10.2.3
2023-12-08T17:31:14.0588755Z yarn: 1.22.21
...
2023-12-08T17:31:40.1810668Z Firebase CLI v13.0.1 is incompatible with Node.js v16.16.0 Please upgrade Node.js to version >=18.0.0 || >=20.0.0

Reverting back to w9jds/firebase-action@v12.9.0 for now.

Here's the raw log ouput: https://pipelinesghubeus9.actions.githubusercontent.com/349Yy7gDu8JyCjIRtZjAkflCUiqU1jcgwAinonAHwZfXn98Ak2/_apis/pipelines/1/runs/1054/signedlogcontent/2?urlExpires=2023-12-08T17%3A36%3A34.3890951Z&urlSigningMethod=HMACV1&urlSignature=b39UdNw%2BtVFC%2Bv3vFgZWZUfgWmXbYqUMeimeDMdUEic%3D

mvhatch commented 9 months ago

version 13.0.1 is using node-16 here, but also using node-18 here. So I guess using the action via w9jds/firebase-action@master is pulling the image w/ the incorrect node-16.

I think you need to retag v13.0.1 pointing to the latest commits that use node-18, then using the action w9jds/firebase-action@v13.0.1 should work

w9jds commented 9 months ago

Yes, I triggered a new tag and the build is running now. Apologies for the issues, it's definitely a downside to how github actions handles docker actions. You can override the docker image that is pulled via the README but that is inconvenient. The updated version should be available now.

lhermann commented 9 months ago

@w9jds it seems like the build didn't succeed? 13.0.1 is still the lates tag.

w9jds commented 9 months ago

Yes, v13.0.1 just was rebuilt the version tag is meant to match the firebase tools so it was just overriden.

tjmtic commented 9 months ago

Going to close this as the action is successful now. Thank you @w9jds for the quick response.