w9jds / firebase-action

GitHub Action for interacting with Firebase
MIT License
922 stars 198 forks source link

Error Docker manifest v13.7.5 #233

Closed mickrip closed 3 months ago

mickrip commented 4 months ago

Here we go again.

Error response from daemon: manifest for w9jds/firebase-action:v13.7.5 not found: manifest unknown: manifest unknown

I don't feel great about complaining about open source software, but every time there's an upgrade, we have a problem like this. Can we collectively figure this out and solve the 'upgrade problem' once and for all?

pinchy commented 4 months ago

If I'm not mistaken, the only changes in the last 5 releases have been the GitHub actions bot "bumping" the version: https://github.com/w9jds/firebase-action/commits?author=github-actions%5Bbot%5D https://github.com/w9jds/firebase-action/compare/v13.7.0...v13.7.5

which aligns with us seeing the issue pretty consistently every Friday midday (AEST). Feels to me that there's a delay between the automated "weekly version bump" and GitHub actions registering the change, which is causing all of us here to pull our hair out.

Is the version bump bot necessary? can we disable it? Or perhaps trigger it to run on Saturday?

I could be wrong - I'm certainly not an expert in git actions!

daneren2005 commented 4 months ago

I believe the problem is that the docker build push isn't running when it should. Looking at the action it says to trigger off of master: https://github.com/w9jds/firebase-action/blob/master/.github/workflows/build-publish.yaml. Looking at the commits it looks like most of the commits trigger the build but not all. v13.7.5 didn't, then v13.7.4/3/2/1 did, then v13.7.0 didn't again, then v13.6.1 through v13.5.1 did, then v13.5.0 didn't again. Not sure I see a rhyme or reason behind some being skipped.

Edit: Looks like in https://github.com/w9jds/firebase-action/commit/9757898184218016e3564be1412e7e969b619883 he already switched to using a PAT which should trigger the workflows. I'm wondering if the permissions for that PAT just weren't setup correctly to allow triggering workflows.

JaredEzz commented 4 months ago

I'm just going to ignore updates for this. The older versions work fine and I, too, am tired of this breaking

w9jds commented 4 months ago

They have limited how GitHub actions trigger, so it automates the update of firebase-tools but the system that publishes a new container isn't triggering. I'm in the process of fixing it, but I'm in the middle of a move so I should get to it soon. Apologies for all the issues!

ENT108 commented 4 months ago

They have limited how GitHub actions trigger, so it automates the update of firebase-tools but the system that publishes a new container isn't triggering. I'm in the process of fixing it, but I'm in the middle of a move so I should get to it soon. Apologies for all the issues!

Any progress maybe? 🤓

w9jds commented 4 months ago

I just pushed an update, hopefully this should make it so it properly published a new container when a new version is found and updated. I'll keep an eye on the next release and hope it is more reliable.

w9jds commented 3 months ago

I have figured out the issue with the docker deployment, I'm currently looking into it not possibly using the correct version of the repo but it shouldn't fail to publish an image anymore.