w9jds / firebase-action

GitHub Action for interacting with Firebase
MIT License
926 stars 199 forks source link

weekly actions bot "bumping" the version causes docker manifest error #235

Closed pinchy closed 4 months ago

pinchy commented 5 months ago

The weekly "bump" to the version results in a docker manifest error each time:

  /usr/bin/docker pull w9jds/firebase-action:v13.8.1
  Error response from daemon: manifest for w9jds/firebase-action:v13.8.1 not found: manifest unknown: manifest unknown

This is the same root cause for issues https://github.com/w9jds/firebase-action/issues/233 and https://github.com/w9jds/firebase-action/issues/232

I can't see a reason to have this version bump, there doesn't appear to be any material changes aside from the version text incrementing each time: https://github.com/w9jds/firebase-action/compare/v13.7.0...v13.8.1

Could we disable the weekly version bump bot until GitHub actions is a bit more stable perhaps?

ENT108 commented 5 months ago

same here

ENT108 commented 5 months ago

Screenshot 2024-05-09 at 10 10 48

downgrading is not helping event though dicker imgae is present:

https://hub.docker.com/layers/w9jds/firebase-action/v13.8.0/images/sha256-471231ad74a43fbdbaa89cc71376df102a5cbf5b8f31b084ffd847c3ae0e978f?context=explore

pinchy commented 5 months ago

Failed again on the version bot bump to 13.10.0 Is it possible to disable this version bump?


Pull down action image 'w9jds/firebase-action:v13.10.0'
  /usr/bin/docker pull w9jds/firebase-action:v13.10.0
  Error response from daemon: manifest for w9jds/firebase-action:v13.10.0 not found: manifest unknown: manifest unknown
  Warning: Docker pull failed with exit code 1, back off 7.39 seconds before retry.
  /usr/bin/docker pull w9jds/firebase-action:v13.10.0
  Error response from daemon: manifest for w9jds/firebase-action:v13.10.0 not found: manifest unknown: manifest unknown
  Warning: Docker pull failed with exit code 1, back off 4.127 seconds before retry.
  /usr/bin/docker pull w9jds/firebase-action:v13.10.0
  Error response from daemon: manifest for w9jds/firebase-action:v13.10.0 not found: manifest unknown: manifest unknown
Error: Docker pull failed with exit code 1```
catalystStephen commented 5 months ago

me2

w9jds commented 5 months ago

I'm working on a fix it got closer to working but failed at the final step this time.

pinchy commented 5 months ago

Thanks @w9jds , I appreciate the attention you're giving this. The repo is super useful to us here (which is why we find out pretty quick when something goes down as we use it constantly!)

w9jds commented 5 months ago

Here is the last job, as you can see it almost got it working, I just had an issue with passing outputs between stages. https://github.com/w9jds/firebase-action/actions/runs/9183135041

I pushed another update to the action that handles auto bumping, so hopefully the next bump should work as expected.

Zinoka commented 5 months ago

Hello @w9jds, Do you have some news about the manifest error ?

pinchy commented 5 months ago

Failed again for the latest version bump.

Screenshot 2024-05-29 at 8 00 37 PM

Is it possible to kill the version bump bot? We all love the codebase, and I feel awkward having to report the same bug each week, makes it tricky for you to maintain!

w9jds commented 4 months ago

Again, I'm working on a fix. Each version is helping me catch and fix things. I believe the next one should work, docker was rejected some tagging and pushes.

pinchy commented 4 months ago

Alas it failed again. :( Maybe it's easier if we disable/remove the bot please? Maybe a few of us can fork the repo without the bot?

w9jds commented 4 months ago

As stated in the README if you want to keep a specific version you can specify the version of the action you want to use. Using Master is always a risky move (you can also use the setup-firebase action I created which is faster and way more customizable). I have successfully fixed the auto bumping action though, I went ahead and just kept reverting the changes and triggering the action until I got the docker issues fixed (I am looking into it possibly not publishing the new firebase-tools, but it won't not find the image anymore)