search

wKoza / ngx-upload

Ngx-upload is an upload module for Angular Ivy ready
30 stars 15 forks source link

Fix disableMultipart option of HTTPClientUpload #49

Closed banksemi closed 5 years ago

banksemi commented 5 years ago

The disableMultipart option is existed in 'HTTPClientUpload' class.

But, this option did not working in the 'HTTPClientUpload'.

So I fixed it.

codecov-io commented 5 years ago

Codecov Report

Merging #49 into master will decrease coverage by 0.37%. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
- Coverage   66.66%   66.28%   -0.38%     
==========================================
  Files           7        7              
  Lines         351      353       +2     
  Branches       41       42       +1     
==========================================
  Hits          234      234              
- Misses         91       92       +1     
- Partials       26       27       +1
Impacted Files Coverage Δ
src/services/httpClientUpload.service.ts 53.33% <50%> (-2.49%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eaf9529...84d0f03. Read the comment docs.

wKoza commented 5 years ago

Thanks @banksemi , After refactoring, I prefer set this option on InputFileOptionsand DropTargetOptions

closes by PR #61