wa0x6e / Cake-Resque

Resque plugin for CakePHP : for creating background jobs that can be processed offline later
MIT License
159 stars 56 forks source link

Track tmp test empty dir. #20

Closed bar closed 11 years ago

bar commented 11 years ago

So that Resque_Job_CreatorTest tests passes.

wa0x6e commented 11 years ago

Tests already pass, I don't see the point of that edit

bar commented 11 years ago

because, you already have that tmp dir :p, but it is not tracked, clone the repo and you will understand what I mean

wa0x6e commented 11 years ago

The Temp directory is not tracked either, the PR just change the name of the folder, it doesn't do any other things that make it traceable.

All the travis build clone the repo, and they passed the tests : https://travis-ci.org/kamisama/Cake-Resque/jobs/6872684

bar commented 11 years ago

The pr tracks tmp/empty file, which makes tmp tracked. I just changed the name to be consistent with unix hierarchy :)

Also, tmp dir must have others permissions so that files can be created inside.