search

wa0x6e / Cake-Resque

Resque plugin for CakePHP : for creating background jobs that can be processed offline later
MIT License
159 stars 56 forks source link

Duplicate shell param (-q). #47

Open bar opened 10 years ago

bar commented 10 years ago

I'm adding documentation to console sub commands and missing options (not positional params) to the missing sub commands from CakeResqueShel; be enqueue, enqueueIn, enqueueAt, and as start, they accept a queue but when I was adding that I noticed the short param -q is used by Shell to enable quiet output.

./Console/cake CakeResque.CakeResque
--quiet, -q    Enable quiet output.
./Console/cake CakeResque.CakeResque start -h
--quiet, -q               Enable quiet output.
--queue, -q               Name of the queue. If multiple queues, separe
                          with comma.

Would you mind if I change the -q param to something else? If yes, what would you like it to be?¿

wa0x6e commented 10 years ago

Solution 1: Remove the short version, and always use --queue. Solution 2: Remove the default --quiet from the option. It's useless since it's already been overwritten by --queue

bar commented 10 years ago

Solution 3: Change the short version to another letter.

Nevertheless, I think I prefer solution 2, what do you think?

wa0x6e commented 10 years ago

+1 for Number 2

johannesnagl commented 10 years ago

+1 for Number 1