search

wa0x6e / Cake-Resque

Resque plugin for CakePHP : for creating background jobs that can be processed offline later
MIT License
159 stars 56 forks source link

[Cake-2] Prevent sending signals to PIDs not originating from the current host #93

Closed mfn closed 2 years ago

mfn commented 9 years ago

Summary

When using multiple server to run workers, the CakeResqueShell understands that the name pattern contains the hostname but does not respect it when sending signals to the PIDs.

This will lead to wrong processes receiving the kill signal. This PR prevents this by simply ignoring those workers.

Note

Although I created this PR in 2015, I updated it recently because I missed that it was against the master branch, which is already switched to CakePHP3 but I need this change for CakePHP2!

Links

catearcher commented 8 years ago

+1

mfn commented 3 years ago

After more testing I realized that the resque-status package also needs more refinement to make this work, see https://github.com/wa0x6e/ResqueStatus/pull/9

mfn commented 2 years ago

Closing, no longer using CakeResque