search

wa0x6e / php-resque-ex

PHP port of resque (Workers and Queueing), with phpredis support, and more logging options
MIT License
137 stars 92 forks source link

Support for Monolog 2 #51

Open boboudreau opened 5 years ago

boboudreau commented 5 years ago

Monolog 2 removed all non-PSR3 calls including all add*() methods. By using these methods, this library maintains Monolog 1 compatibility, but does not break when using Monolog 2.

boboudreau commented 5 years ago

Failing tests are because this library still attempts to test against PHP 5.5, and doesn't specify which version of PHPUnit to use in the composer.json file. Not sure if this library is even maintained anymore, but I'd be willing to work with whoever to bring some of the testing up to date if there's desire to do so.

boboudreau commented 5 years ago

Travis (and the world, really) does not support PHP <= 5.5, so it's probably a good idea to remove that from the travis.yml file, here, too. The rest of the tests pass. I'll let this simmer for a bit and then will update travis.yml if we need a passing PR to make it into master.

mfn commented 4 years ago

See related issue I reported a bit before this PR => https://github.com/wa0x6e/php-resque-ex/issues/53

@wa0x6e are you still active?

wa0x6e commented 4 years ago

Let's go ahead and remove php 5.5 from travis, and I'll merge this PR

mfn commented 4 years ago

@boboudreau are you still up to finishing this PR? Otherwise I would be available too.

wa0x6e commented 4 years ago

Please remove the old php version from travis, so test can pass, and I'll merge it