Fix SMBJ checking existing file or folder behavior.

wa2c / cifs-documents-provider

CIFS Documents Provider

MIT License

232 stars 25 forks source link

Fix SMBJ checking existing file or folder behavior. #60

Closed RebelliousX closed 7 months ago

RebelliousX commented 7 months ago

See https://github.com/wa2c/cifs-documents-provider/commit/85e400d9cfdfd578b69f95b0a916b0cb89b1e8db#commitcomment-134106897 for details

TL;DR: fileExists() and folderExists() throw exception if the path is invalid. Using both functions at the same time for the same path to check the existence of file or directory will throw SMBApiException type exception. If the path is for a file, it can't be for a directory, and vice versa.

RebelliousX commented 7 months ago

@wa2c This video will show the bug I am talking about. And this PR fixes this issue.

As for the notifications, they are still bad after the change with last workManager commit. I have a solution, but you may or may not approve of it. But one thing at a time. 😁