Implemented solution to issue #25 (1st test). Renamed method create to network_create in networks.py from ircb cli

waartaa / ircb

A versatile IRC bouncer for humans

MIT License

49 stars 15 forks source link

Closed PolBaladas closed 8 years ago

PolBaladas commented 8 years ago

Implemented solution to issue #25 (1st test). Renamed method create to network_create in networks.py from ircb cli.

Now the user can configure ircb with a YAML file.

rtnpro commented 8 years ago

@PolBaladas Please follow https://pypi.python.org/pypi/flake8 for coding styleguide and linting.

rtnpro commented 8 years ago

Commit message should be small and concise. You can follow the guidelines here: https://github.com/erlang/otp/wiki/Writing-good-commit-messages

PolBaladas commented 8 years ago

I've fixed all the pep8 style errors. Do I push them to my fork and create another PR? Thanks for the tips!

PolBaladas commented 8 years ago

Fixed! Thanks (did not see it).

rtnpro commented 8 years ago

Could you stash your commits into one?

ralphbean commented 8 years ago

@rtnpro by stash perhaps you mean squash?

slick666 commented 8 years ago

Is the only thing left to merge this PR squashing the merges down to a single commit?

slick666 commented 8 years ago

Squashed and rebased in #57

pypingou commented 8 years ago

Looks like this needs to be rebased as it currently conflict and thus cannot be merged

slick666 commented 8 years ago

@pypingou this should be closed and we can merge these changes in on #57

pypingou commented 8 years ago

Let's close then :)