Closed rtnpro closed 8 years ago
@pypingou Now, this is what I was talking about... realtime publishers
@sayanchowdhury see, if you can run ircb/publishers/__init__.py
?
+ self.results = deque(maxlen=self.limit)
+ self.index = {}
self.results
is thus limited in size but self.index
doesn't seem to be nor does it seem to be cleaned anywhere. Won't this end up being a memory leak or some sort?
@pypingou Yes, I know about the issue of self.index
not getting cleaned. It seems like I have to do it manually everytime I add data to a queue which is full.
@pypingou Thanks for the review. I'd also like to know about your feedback on this concept of implementing a realtime publisher, powered by a dispatcher based store. That's what I meant when I said I was inspired by meteor
, flux
, fedmsg
, hehe :) It did not turn up to be that ugly. What I am trying to get at is come up with a design pattern to make realtime stores, and in the long run, we can make it a standalone library, if we succeed with it in waartaa
/ircb
.
Thanks, @pypingou for the review. I have fixed all the issues you pointed out. Merging it.
This implements publishers from which we can subscribe to data (say, latest message logs in a channel) in realtime.