waasilzamri / callmeter

Automatically exported from code.google.com/p/callmeter
0 stars 0 forks source link

Number match issue #980

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
When I'm entering 061% and +361% it seem that they're matching the number 1221. 
How is this possible?

Original issue reported on code.google.com by mydexte...@gmail.com on 24 May 2014 at 7:29

GoogleCodeExporter commented 9 years ago
Forgot to mention, using Call Meter 3G v3.11.2

Original comment by mydexte...@gmail.com on 24 May 2014 at 7:43

GoogleCodeExporter commented 9 years ago
I guess, the 1221 is converted to +361221 because of your international prefix.
+361% matches +361221.

There is a complex strategy for converting local numbers to international 
format. It might be wrong for hungary's numbers. so please comment on it to let 
me fix it.

1. if the local number starts with "+", it is already international
2. if the local number starts with "00", the leading "00" is replaced with "+"
3. if the local number starts with "0", the leading "0" is replaced with the 
international prefix
4. if the local number starts with the interantional prefix without "+", it is 
prepended with "+"
5. if your prefix is not "+49" (Germany) or "+44 (Switzerland), the prefix is 
just prepended to the number
6. in any other case: nothing is converted

Please note, that case 6 is only possible in Germany and Switzerland right now.
At the moment, case 5 is only there, because some/most countries do not strip 
leading zeros.. But I can never be sure.

It would be great, if you have a strict rule for Hungary on how to convert the 
numbers.

Original comment by f...@ub0r.de on 27 May 2014 at 6:37

GoogleCodeExporter commented 9 years ago
That's interesting. I'm not sure what you're asking from me, but the phone 
numbers in Hungary are exactly as it is described here:
https://en.wikipedia.org/wiki/Telephone_numbers_in_Hungary

There are some more short numbers like: 1221,1270,1220,1230 etc. and they're 
never prefixed and can be called from all mobile networks as is. The call log 
itself also shows the number as: 1221 and not +361221.

So I guess the problem is that these short numbers should not be prefixed with 
+36

Original comment by mydexte...@gmail.com on 27 May 2014 at 10:19

GoogleCodeExporter commented 9 years ago
this should fix your problem by hopefully not breaking others. ;)

numbers with length <7 are now not transformed into international format.

Original comment by f...@ub0r.de on 2 Jun 2014 at 7:56

Attachments:

GoogleCodeExporter commented 9 years ago
It seems to be working.

Thanks!

Original comment by mydexte...@gmail.com on 2 Jun 2014 at 8:05

GoogleCodeExporter commented 9 years ago
migrated to: https://github.com/felixb/callmeter/issues/32

Original comment by f...@ub0r.de on 31 Aug 2014 at 9:18