baconsplit
commented
11 months ago related issue: https://github.com/wabbajack-tools/wabbajack/issues/2080
Closed baconsplit closed 10 months ago
baconsplit
commented
11 months ago related issue: https://github.com/wabbajack-tools/wabbajack/issues/2080
Mieekaserra
commented
11 months ago Its not closing them as a band-aid fix for #2440
As closing them is causing the memory leak which is causing the above crash.
baconsplit
commented
11 months ago Alright but this seems to also fill up my memory, but I haven't seen the crash yet as described in #2440 I have to restart wabbajack from time to time now tho. But good, if it is a known problem and fix for something else. You can close this ticket then I guess
Nostras
commented
11 months ago Having the same issue. I have lots and lots of RAM and swap which causes the GPU VRAM to fill up first for me causing Windows to behave funny.
But yeah, it seems that this problem got reintroduced in 3.4.
Althro
commented
10 months ago Wabbajack is worked on by people in their free time. You are welcome to contribute a fix should you be skilled in coding, but until then this will stand.
Althro
commented
10 months ago The application works for what it is intended to. The webview only occurs on non nexus premium installations. Saying something should be pulled when multiple thousand people have successful installs each day is not conducive to getting a fix in.
As stated before, you are welcome to contribute a fix but until then I would advise you do not continue down this track.
EzioTheDeadPoet
commented
10 months ago @EzioTheDeadPoet sorry but could you please remove the "not a bug" tag, and instead maybe even suggest a date for a fix? With this behavior actually killing a whole system (and not just simply inhibiting the use of the program itself), this is a major blocking issue and no one should use it !
This is not a bug.
This is a necessary INTENDED behavior to keep the program usable for especially manual installations but also the automated ones that occasionally need some manual downloads.
And as the needs-work tag also implies we know that this is only a band-aid fix that will be worked on once we can figure out why the issue people with manual downloads had is happening and people have in general more time to work on the app and debug the issue this is mitigating.
Also if it gets to bad you can just restart WJ and it will analyze all the files you have already downloaded. And with people being expected not download a list manually in a few hours it is expected that people will also close the app.
Or you get nexus premium where WJ only needs to open webview windows for some manual external sources and LoversLab.
If you think you can fix the issue that this is mitigating we are very open to welcome your contributions.
Also if you want to read more on why this change had to be made refer to this post and project update on the projects Patreon: https://www.patreon.com/posts/93180808
Nostras
commented
10 months ago This is a problem for me because I click the download button whilst I have a stream open on my other screen where I watch a stream or something. Because the VRAM gets full my video/stream crashes and effectively freezes the system. It's quite surprising that this is even possible at all honestly, god bless Windows/AMD/whoever is supposed to properly deal with it.
Funnily enough I have had the same issues @EzioTheDeadPoet refers to in the Patreon project some time back, but I thought it was the nexusmods themselves doing a funny. You could argue that by doing this you're effectively making Wabbajack guaranteed to be the issue instead of users thinking it's, well, what I thought.
As a developer myself it pains me to see it being treated like this, I primarily have an issue with the 'not-a-bug' tag, because frankly both options I'd consider "bugged". If you're going to let this be a bug issue I'd strongly recommend coding in a reference to this topic, the patreon post and/or something that describes this issue whenever a user is going to download 50* mods or more from nexusmods and does not have premium. A popup and an 'I agree' button should be dandy.
Not to sound ungrateful, I'm really glad this tool exists, but please inform the user about this issue instead of what happened here.
Althro
commented
10 months ago You do realize your clicker is against Nexus terms of service....
Nostras
commented
10 months ago You do realize your clicker is against Nexus terms of service....
Oh yeah I am very well aware. I, however, do not promote it nor condone it. I heard of it yes. But that's not of your or Wabbajacks concern.
You know what, it adds nothing to the conversation. Removed it.
EzioTheDeadPoet
commented
10 months ago As a developer myself it pains me to see it being treated like this, I primarily have an issue with the 'not-a-bug' tag, because frankly both options I'd consider "bugged". If you're going to let this be a ~bug~ issue I'd strongly recommend coding in a reference to this topic, the patreon post and/or something that describes this issue whenever a user is going to download 50* mods or more from nexusmods and does not have premium. A popup and an 'I agree' button should be dandy.
Not to sound ungrateful, I'm really glad this tool exists, but please inform the user about this issue instead of what happened here.
You are free to add functionality for this in your free time. We do welcome external contributions.
Nostras
commented
10 months ago As a developer myself it pains me to see it being treated like this, I primarily have an issue with the 'not-a-bug' tag, because frankly both options I'd consider "bugged". If you're going to let this be a ~bug~ issue I'd strongly recommend coding in a reference to this topic, the patreon post and/or something that describes this issue whenever a user is going to download 50* mods or more from nexusmods and does not have premium. A popup and an 'I agree' button should be dandy. Not to sound ungrateful, I'm really glad this tool exists, but please inform the user about this issue instead of what happened here.
You are free to add functionality for this in your free time. We do welcome external contributions.
Sadly I'm not that kind of programmer, C# is alien to me and I especially do not develop against Windows myself. Perhaps I can take a look some time, but a language one is not experienced in in a project this size is... unlikely to yield a good result in reasonable effort for me.
tr4wzified
commented
10 months ago This is definitely a bug, it was a temporary workaround. Got a fixed version if you guys are interested: https://github.com/wabbajack-tools/wabbajack/pull/2478
tr4wzified
commented
10 months ago Link to a compiled release: https://mega.nz/file/sTRCAarR#k1rLmGrk5xA084L-fA2aid3pJWVm3YDL1KupbAxoMkE
tr4wzified
commented
10 months ago Fixed in 3.4.2.0+
Describe the bug
Wabbajack doesn't seem to exit finished downloads and their Webview2 instances Additional Context
OS : Up to date Windows 10 Game : Skyrim SE Wabbajack not located in a system folder
Wabbajack Version
3.4.0.0
Logs Only the download finished logs.