wabbajack-tools / wabbajack

An automated Modlist installer for various games.
https://www.wabbajack.org/
Other
707 stars 133 forks source link

UI Lockup when downloading mod list #2593

Open Dimencia opened 4 days ago

Dimencia commented 4 days ago

Describe the bug

When downloading files for a modlist for the first time, the UI becomes unresponsive - the window can't be moved, and nothing new is shown after it displays just the first file name that it's downloading. During this time, files are still being downloaded. If you exit wabbajack while unresponsive, and then restart it and start the download again, it is still unresponsive despite starting with a different file.

If wabbajack is closed while unresponsive, the downloaded files can't be deleted because they are still in use

After a few minutes, the UI starts to respond again. Restarting wabbajack after this point, when it is responding again, it no longer becomes unresponsive when starting the download

Could be related to having a large number of archives to validate, 1500 initially, only about 275 when it didn't cause UI lockup - possible threadpool starvation? Or might be related to hashing or validation of archives, or similar logic that runs once and then saves the results to disk somewhere Or maybe just related to the webview update

I was intending to do more testing of other scenarios after restarting PC because of the stuck files, but then windows wouldn't restart right and I had to force a shutdown, and then something in the boot got messed up, and all kinds of weird stuff and I'm afraid to mess with it now that it's working again, beyond just finishing my downloads. So... it's entirely possible something on my machine is messed up, if you can't reproduce it

Additional Context

Win10, SSE, Elysium and Tempus Maledictum modlists (tested both just to check, both behave the same - logs are from Elysium)

Notable: Skyrim is in Program Files, but I've ran a batch file (a long time ago) to take ownership of that folder for my account, which usually prevents any issues I tried to move the install to a non-protected folder, using steam UI to move the install, but Wabbajack then failed to initiate the download at all because it detected a steam vdf pointing at the Program Files folder (but that folder no longer existed). Assumedly a second vdf was created somewhere with the correct new path... or Steam screwed something up, not sure

Wabbajack Version

3.7.0.0 - auto-updated from a previous version just before attempting the install

Logs

  1. First attempt, I closed Wabbajack while it was unresponsive Wabbajack.02.log
  2. Second attempt, I cleared all files and started the download again - UI became unresponsive. After a few minutes, just before the end of the log file, it started responding again Wabbajack.current.log
  3. Once it was responding again, I restarted Wabbajack and there was no UI lockup when starting the download again: Wabbajack.current2.log