search

wabbajack-tools / wabbajack

An automated Modlist installer for various games.
https://www.wabbajack.org/
Other
732 stars 136 forks source link

Extraction error due to string culture differences #903

Open Sederien opened 4 years ago

Sederien commented 4 years ago

Describe the bug During install of a list, the installer may fail due to a mod similar to Rayek's End having a degree symbol in one of its filenames. When extracting, the expected filename isn't as expected due to Windows interpreting the symbol natively in another language.

Within Rayek's End - SSE Expanded Edition 1.7-8285-1-7.zip as an example, there is the archived file "Meshes\Oaristys\Clutter\Mirror°.nif" which is expected by WJ... but when a Windows10 install with Japanese base (note: ENGLISH is used as main, but Windows may still interpret symbols differently) it reads the file as "Meshes\Oaristys\Clutter\Mirror・nif" which does not match. Thus, the installation fails.

Additional context OS (Win 10 Japan running English as main) and Game type (SSE)

Logs Wabbajack 2020-06-01 16_48_16.log

Above is reinstall attempt, below is after manually extracting and renaming the file in question to the expected "Meshes\Oaristys\Clutter\Mirror°.nif" within the mod directory in profile.

Wabbajack 2020-06-01 16_56_44.log

erri120 commented 4 years ago

https://github.com/wabbajack-tools/wabbajack/blob/master/Wabbajack.VirtualFileSystem/Context.cs#L221 Might have to implement custom key finder/string comparer that is string culture independent.

Tobermann459 commented 4 years ago

I have the Same Problem how do i fix it? when i rename the file it just downloads it wrong again i just cant figure out how to do this

Sederien commented 4 years ago

I have the Same Problem how do i fix it? when i rename the file it just downloads it wrong again i just cant figure out how to do this

See here: https://github.com/ForgottenGlory/Living-Skyrim-2/issues/69

Sederien commented 4 years ago

Whoops. Wrong button. Still low priority.

github-actions[bot] commented 3 years ago

Marked as stale due to inactivity

github-actions[bot] commented 3 years ago

Closed due to inactivity

UltraHex commented 3 weeks ago

This is still a bug.

Why close issues due to inactivity? Just leave them labeled as stale.

UltraHex commented 3 weeks ago

Want activity to keep bugs open? Have a datapoint:

Wabbajack version: v3.7.1.1 Modpack: https://www.nexusmods.com/skyrimspecialedition/mods/76466?tab=files&file_id=534208 Offending archive: https://www.nexusmods.com/skyrimspecialedition/mods/119731?tab=files&file_id=502388 My OS: Windows 11 My system locale: English (Canada) Modpack's probable system locale: English (United States)

Error: [ERROR] (Wabbajack.InstallerVM) Sanity check error extracting D:\Modding\Bethesda\Skyrim SE\Downloads\Soule-like Music-119731-1-0-1716042065.zip - 65 results, expected 66|System.Exception: Sanity check error extracting D:\Modding\Bethesda\Skyrim SE\Downloads\Soule-like Music-119731-1-0-1716042065.zip - 65 results, expected 66