search

wachub / jaitools

Automatically exported from code.google.com/p/jaitools
0 stars 0 forks source link

FindBugs reports multithreading problems in DiskMemTileCache #187

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Running FindBugs on the utils module uncovered a bunch of warnings about 
possible unsafe access to fields in DiskMemTileCache.

Replace the synchronized qualifier on methods with use of a ReentrantLock and 
try to be more consistent.

Original issue reported on code.google.com by michael.bedward@gmail.com on 23 Jun 2011 at 12:00

GoogleCodeExporter commented 9 years ago 
Removed all synchronized method qualifiers and now use a single ReentrantLock.

There is a potential problem if sub-classes are defined since some of the 
fields are protected rather than private (at user request) but I figure it's up 
to developers to be careful in that regard.

Committed to trunk (r1812) and 1.2.x branch (r1813)

Original comment by michael.bedward@gmail.com on 23 Jun 2011 at 12:09