wackerl91 / luna

Moonlight Launcher for Kodi
GNU General Public License v3.0
100 stars 22 forks source link

Mapping files for gamepads obselete #152

Open skasch opened 7 years ago

skasch commented 7 years ago

Expected Behaviour: Sony DualShock 4 controller (PS4) working with custom mapping file.

Actual Behaviour: Sony DualShock 4 controller (PS4) not answering user inputs.

After some research in the moonlight-embedded package, I realized that since the 1d7c2be7e2a967f40b4a8047bf16d24c5e45dd8d commit from April 8th, which is therefore included in the 2.4.0 release form June 11th, the package changed the way it manages controller inputs. If I understand correctly the modifications, gamepad specific mapping files are not necessary anymore.

I therefore fixed the issue by simply removing the mapping file used for my controller in the Luna GUI, and it now works as intended.

I am posting this as an issue, because I believe something might be done on Luna's side to take into account these latest modification in moonlight-embedded (maybe disabling controller custom mapping, maybe just a mention in the wiki?).

Anyway, thanks for this great addon =)

wackerl91 commented 7 years ago

Thanks for bringing this to my attention! Indeed looks like controllers are now auto-mapped, plus the entire map function has been removed.

That's actually great news for me, as controller mapping in Luna has always been difficult and didn't work reliably (like ... ever!).

I'll include a mention in the readme (linking to this issue) and will remove / disable the entire controller mapping feature in the next release. This issue will stay open until both is done.

BoBBer446 commented 7 years ago

what does it mean? i installed osmc clean new from iso.

I install moonlight embedded over ppa i install Luna i config luna like this: https://github.com/wackerl91/luna/issues/148#issuecomment-289383200

Now i have to map xbox360.map or i can run ?