search

wackou / bts_tools

BitShares delegate tools
GNU General Public License v3.0
30 stars 45 forks source link

[Hero & Hertz] 'bitshares-pricefeed' referencing bitUSD | BTS_Tools referencing BTC:USD (bitUSD|BTC:USD) #46

Open grctest opened 6 years ago

grctest commented 6 years ago

I created a similar issue on xeroc's repo.

There's a difference in price BTS:USD reference between the two Bitshares price feed libraries. @Xeroc's scripts reference bitUSD meanwhile bts_tools references BTS:BTC:USD price feeds. This is the potential source of price feed differences for Hertz: https://btsapi.grcnode.co.uk/home

What's the appropriate USD reference for Hero and Hertz? bitUSD:BTS and/or BTS:BTC:USD?

Cheers

grctest commented 6 years ago

Would it be OK to involve the python-bitshares library as a dependency for retrieving data from the Bitshares blockchain, or should I perform a GET request against the HUG REST API within the price feed script?

grctest commented 6 years ago

I believe that the large price feed difference between bts_tools and the other price feeds was down to a programming error solved: https://github.com/wackou/bts_tools/pull/50

The original question is however still valid - referencing bitUSD vs BTS:BTC:USD, one/the other or a mix of both?

grctest commented 5 years ago

BSIP 76 (https://github.com/bitshares/bsips/issues/221) has now set fixed (fake) price feeds for bitUSD.

Since this price feed script uses bitUSD as the price feed reference it's now producing inaccurate Hertz price feeds.

Can an alternative to bitUSD be provided for Hertz to become accurate again?