search

wackywendell / tess

Python bindings to the voro++ library.
Other
36 stars 10 forks source link

Unnecessary Memory Allocation #7

Open pmrv opened 5 years ago

pmrv commented 5 years ago

Related to #4.

https://github.com/wackywendell/tess/blob/22c19df952732f9749637d1bf6d7b676b6c7b26c/tess/__init__.py#L157

On line 157 in the Container __init__ the python code instructs voro++ to allocate space for len(points) per block, which is way too much, see original docs. (The default for the cli tool is 8).

For MWE check this file. Trying to tessellate with tess causes the process to be OOM-killed on my machine (8GB), while the voro++ cli has no problems.

wackywendell commented 5 years ago

@prmv Thank you, good find! I did minimal investigation, so I haven't entirely verified that this was better, but can you check if the change in #8 worked for you?

pmrv commented 5 years ago

Hey, sorry for the silence.

That doesn't seem to be the full problem. I will look into it more deeply and report back.