search

wacl-york / mcm-web

Code for the MCM web application
1 stars 1 forks source link

KPP on the MCM web pages #244

Closed RolfSander closed 6 months ago

RolfSander commented 6 months ago

Hello @stulacy,

Thanks again for all your work on the KPP export!

I have two comments on the new web page, which are not directly related to the export function. So, instead of reopening issue https://github.com/wacl-york/mcm-web/issues/177, I've created a new issue here.

1) The complete MCM 3.3.1 mechanism can be downloaded at:

https://mcm.york.ac.uk/MCM/about/archive

It would be nice to update the file mcm_3-3-1_kpp_complete.kpp, which is part of the downloaded zip or tar.gz archive.

2) The web page

https://mcm.york.ac.uk/MCM/export

says that you'll also need a copy of mcm_constants.f90. This should be changed to the new name constants_mcm.f90.

The name of the downloaded file is actually correct, only the text on the web page needs to be changed.

RolfSander commented 6 months ago

I'd like to add one more item:

  1. We have have created a minimal working example (MWE) that shows how you can use the MCM-generated KPP files in a small Fortran90 model. The MWE and a detailed explanation how to run it can be found here:

    https://github.com/KineticPreProcessor/KPP/tree/main/examples/mcm

    If you think that this may be useful for your MCM users, you could mention the URL somewhere on the KPP export page.

stulacy commented 6 months ago

Happy new year Rolf! Thanks for pointing these out, I'll create a PR to address them shortly.

stulacy commented 6 months ago

I've made these changes and updated the live site. Once you've had time to have a quick look at them and let me know you're happy I can close this issue, cheers.

RolfSander commented 6 months ago

Happy new year, Stuart!

Everything is perfect, thanks for taking care of these issues!