wacon-internet-gmbh / wacon_cookie_management

WCM ist eine TYPO3 Extension, die es den Besuchern Ihrer Website erlaubt, die benutzten Cookie-Einstellungen selber zu kontrollieren.
https://www.wacon.de
GNU General Public License v2.0
10 stars 7 forks source link

Event Handlers not hooked #72

Open HoffErik-JohnerInst opened 1 year ago

HoffErik-JohnerInst commented 1 year ago

Bug Report

Expected behavior Cookie banner functionaly and event handlers should be hooked after after the DOM is present.

Current Behavior Cookie Banner is not functional and event handlers are not hooked.

Steps to reproduce

Environment

Possible Solution Move all event handlers into the $(document.ready) in waconcookiemanagement.js to make sure, the cookiebox is in the DOM when event handlers are hooked.

Additional context This probably happens because the event handlers are added as soon as the file is executed. In our case, this happens before the DOM is fully loaded, so all eventhandlers are not applied since the classes are not set at execution time.

This is probably not the case on every webpage where this plugin is active. Nevertheless, is there any advice how we could solve this problem without the need of modifying plugin files directly, after every update?

Thank you for any answers!

PKuhlmay commented 8 months ago

Fixed in https://github.com/wacon-internet-gmbh/wacon_cookie_management/commit/d12e89b87e505eaa8ecfe22cd7182e8067ef3020

Erik-Hoffmann commented 8 months ago

@PKuhlmay thank you!

PKuhlmay commented 8 months ago

Hi @Erik-Hoffmann Could you test it? Did it already work for you? It is not released or tagged yet.

Erik-Hoffmann commented 8 months ago

I am working on it ;)

Erik-Hoffmann commented 8 months ago

@PKuhlmay it's working like a charm!