search

wadahiro / keycloak-discord

Keycloak Identity Provider extension for Discord
121 stars 64 forks source link

Conditionally append discriminator if not 0 #34

Open rpeper opened 1 year ago

rpeper commented 1 year ago

With unique usernames rolling out, usernames will no longer have a discriminator. During the migration user will have a '#0' discriminator after updating. This change will conditionally append the username given to Keycloak if the discriminator is not 0.

https://support-dev.discord.com/hc/en-us/articles/13667755828631-Updating-Apps-to-Support-Unique-Usernames#h_01GYA87X9QZ19H2X6PJ3M35ZDH

NotActuallyTerry commented 1 year ago

@wadahiro seeing as Discord has broadly pushed the username update out, and it's more likely that an active user will have a discriminator of 0, could we get this PR merged?